Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 47694200D2D for ; Fri, 13 Oct 2017 00:58:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 45F0F160BE5; Thu, 12 Oct 2017 22:58:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8E0FC1609E8 for ; Fri, 13 Oct 2017 00:58:09 +0200 (CEST) Received: (qmail 20735 invoked by uid 500); 12 Oct 2017 22:58:08 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 20724 invoked by uid 99); 12 Oct 2017 22:58:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Oct 2017 22:58:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7A890C710F for ; Thu, 12 Oct 2017 22:48:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id sZPGZnpCjvxv for ; Thu, 12 Oct 2017 22:48:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id ED75761126 for ; Thu, 12 Oct 2017 22:48:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 03D20E257E for ; Thu, 12 Oct 2017 22:48:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E11AB24000 for ; Thu, 12 Oct 2017 22:48:01 +0000 (UTC) Date: Thu, 12 Oct 2017 22:48:01 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12260) MasterServices needs a short-back-and-sides; pare-back exposure of internals and IA.Private classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 12 Oct 2017 22:58:10 -0000 [ https://issues.apache.org/jira/browse/HBASE-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202749#comment-16202749 ] stack commented on HBASE-12260: ------------------------------- .013 fix tests (except one I can't figure that comes of our using mocks over HMaster than over RegionServer around the crptic wal splitting engine). Lets see what hadoopqa says. Will look at rb in meantime. I think patch ready to go. Can address the TODOs above in follow-ons. > MasterServices needs a short-back-and-sides; pare-back exposure of internals and IA.Private classes > --------------------------------------------------------------------------------------------------- > > Key: HBASE-12260 > URL: https://issues.apache.org/jira/browse/HBASE-12260 > Project: HBase > Issue Type: Sub-task > Components: master > Reporter: ryan rawson > Assignee: stack > Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-12260.master.001.patch, HBASE-12260.master.002.patch, HBASE-12260.master.003.patch, HBASE-12260.master.004.patch, HBASE-12260.master.005.patch, HBASE-12260.master.006.patch, HBASE-12260.master.007.patch, HBASE-12260.master.008.patch, HBASE-12260.master.009.patch, HBASE-12260.master.010.patch, HBASE-12260.master.011.patch, HBASE-12260.master.011.patch, HBASE-12260.master.012.patch, HBASE-12260.master.013.patch > > > A major issue with MasterServices is the MasterCoprocessorEnvironment exposes this class even though MasterServices is tagged with @InterfaceAudience.Private > This means that the entire internals of the HMaster is essentially part of the coprocessor API. Many of the classes returned by the MasterServices API are highly internal, extremely powerful, and subject to constant change. > Perhaps a new API to replace MasterServices that is use-case focused, and justified based on real world co-processors would suit things better. -- This message was sent by Atlassian JIRA (v6.4.14#64029)