hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs
Date Tue, 31 Oct 2017 17:07:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227119#comment-16227119

ramkrishna.s.vasudevan commented on HBASE-19092:

bq.What you thnking? I think adding static helpers that do read-only ops on current Tag sounds
good. What would you add?
Yes only the readOnly APIs.
bq.For building Tags, you say "... I would go with RegionCPEnv method. " What you thinking?
What would you add sir?
RegionCPEnv will have getCellBuilder(CellBuilderType). So this will allow them to build a
Cell with Tags.
bq.Do we have to? Could we just add to ExtendedCell a getTags?
WE have cloneTags, tagsIterator(Cell) and other APIs which we think CP may use. So all those
we wil add to Extendedcell then? getTags may be a good choice to add to ExtendedCell.
bq.Lets keep talking. Shall we start a doc and attach here so we can work it out before we
go coding? Thanks 
Ok sure. I wont go with the patch now.

> Make Tag IA.LimitedPrivate and expose for CPs
> ---------------------------------------------
>                 Key: HBASE-19092
>                 URL: https://issues.apache.org/jira/browse/HBASE-19092
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 2.0.0-beta-1
>         Attachments: HBASE-19092-branch-2.patch, HBASE-19092_001-branch-2.patch
> We need to make tags as LimitedPrivate as some use cases are trying to use tags like
timeline server. The same topic was discussed in dev@ and also in HBASE-18995.
> Shall we target this for beta1 - cc [~saint.ack@gmail.com].
> So once we do this all related Util methods and APIs should also move to LimitedPrivate
Util classes.

This message was sent by Atlassian JIRA

View raw message