hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs
Date Tue, 31 Oct 2017 09:29:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226504#comment-16226504

ramkrishna.s.vasudevan commented on HBASE-19092:

bq. Like the matching methods, these APIs also act on a Cell. If we are going to have a LP
CellUtil version, I would say, put the Tag's' related methods there..
Yes that is my point too. Even if we want to expose it via RegionCPEnv, we will still need
to add some APIs tht needs to be accessed for CPs.  So to access those APIs we should have
an accessor in RegionCPEnv and so we need a singleton INSTANCE of that UTIL class and anyway
core code also needs it so we will have to do getInstance() and then use those APIs. Instead
a simple LPCellUtil should be simpler.
For now I thought we can add Tags in LP exposed util class. The major matchingXXX() are already
public few variants are private. We can move them to LP if needed. Is there any thing else
that needs to be moved to LP from the current PRivatecellUtil?

> Make Tag IA.LimitedPrivate and expose for CPs
> ---------------------------------------------
>                 Key: HBASE-19092
>                 URL: https://issues.apache.org/jira/browse/HBASE-19092
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 2.0.0-alpha-4
>         Attachments: HBASE-19092-branch-2.patch, HBASE-19092_001-branch-2.patch
> We need to make tags as LimitedPrivate as some use cases are trying to use tags like
timeline server. The same topic was discussed in dev@ and also in HBASE-18995.
> Shall we target this for beta1 - cc [~saint.ack@gmail.com].
> So once we do this all related Util methods and APIs should also move to LimitedPrivate
Util classes.

This message was sent by Atlassian JIRA

View raw message