hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19074) Miscellaneous Observer cleanups
Date Tue, 24 Oct 2017 04:52:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216304#comment-16216304
] 

stack commented on HBASE-19074:
-------------------------------

Ditto in WALObserver, I made the Deprecated for now.

{code}
  /**
   * Called before a {@link WALEdit}
   * is writen to WAL.
   *
   * @return true if default behavior should be bypassed, false otherwise
   * @deprecated Since hbase-2.0.0. To be replaced with an alternative that does not expose
   * InterfaceAudience classes such as WALKey and WALEdit. Will be removed in hbase-3.0.0.
   */
  // TODO: return value is not used
  @Deprecated
  default boolean preWALWrite(ObserverContext<? extends WALCoprocessorEnvironment> ctx,
      RegionInfo info, WALKey logKey, WALEdit logEdit) throws IOException {
    return false;
  }

  /**
   * Called after a {@link WALEdit}
   * is writen to WAL.
   * @deprecated Since hbase-2.0.0. To be replaced with an alternative that does not expose
   * InterfaceAudience classes such as WALKey and WALEdit. Will be removed in hbase-3.0.0.
   */
  @Deprecated
  default void postWALWrite(ObserverContext<? extends WALCoprocessorEnvironment> ctx,
      RegionInfo info, WALKey logKey, WALEdit logEdit) throws IOException {}
{code}

> Miscellaneous Observer cleanups
> -------------------------------
>
>                 Key: HBASE-19074
>                 URL: https://issues.apache.org/jira/browse/HBASE-19074
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-19074.master.001.patch, HBASE-19074.master.002.patch
>
>
> Going through Observers after fixing up MasterObserver, i see a few violations such as
Store returning a MemStoreSize instance (which would let coprocessors inc/dec MemStore size
which would mess us up). This issue is about cleaning these remainders up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message