hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19073) Cleanup CoordinatedStateManager
Date Tue, 24 Oct 2017 20:42:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217649#comment-16217649
] 

Appy commented on HBASE-19073:
------------------------------

So running all master tests passed. I had fork count=5 to make sure that it's not failing
because of some weird concurrency issue in testing.

{noformat}
$ mvn test -Dtest=org.apache.hadoop.hbase.master.Test* -Dsurefire.firstPartForkCount=5 -pl
hbase-server
...

Tests run: 104, Failures: 0, Errors: 0, Skipped: 24


--- maven-surefire-plugin:2.20.1:test (secondPartTestsExecution) @ hbase-server ---
Tests are skipped.
------------------------------------------------------------------------
BUILD SUCCESS
------------------------------------------------------------------------
Total time: 04:37 min
Finished at: 2017-10-24T13:20:08-07:00
Final Memory: 79M/836M
------------------------------------------------------------------------
{noformat}

I have no idea why its failing because the test being changed in this patch, testDelayedDeleteOnFailure,
runs after the test that's failing, testThreeRSAbort. So that can't be it.

Doing another QA run.


> Cleanup CoordinatedStateManager
> -------------------------------
>
>                 Key: HBASE-19073
>                 URL: https://issues.apache.org/jira/browse/HBASE-19073
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-19073.master.001.patch, HBASE-19073.master.002.patch
>
>
> - Remove the configuration hbase.coordinated.state.manager.class
> - Keep following interface since they nicely separate ZK based
> implementation: SplitLogWorkerCoordination, SplitLogManagerCoordination,
> ProcedureCoordinatorRpcs, ProcedureMemberRpcs
> - Replace CSM (interface) + BCSM (unnecessary middle hierarchy) with single
> CSM interface.
> - Don't pass whole CSM object around (with server in it which gives acess to pretty much
everything), only pass the relevant dependencies.
> Discussion thread on dev@ mailing list.
> http://mail-archives.apache.org/mod_mbox/hbase-dev/201710.mbox/%3CCAAjhxrqjOg90Fdi73kZZe_Gxtrqq8ff%2B%3DAj_epptO_XO812Abg%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message