hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jerry He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19072) Missing beak in catch block of InterruptedException in HRegion#waitForFlushes()
Date Mon, 23 Oct 2017 21:31:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215885#comment-16215885
] 

Jerry He commented on HBASE-19072:
----------------------------------

+1

> Missing beak in catch block of InterruptedException in HRegion#waitForFlushes() 
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-19072
>                 URL: https://issues.apache.org/jira/browse/HBASE-19072
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 19072.v1.txt
>
>
> During review of HBASE-18358, [~elserj] found that there was missing break in the catch
block:
> {code}
>           } catch (InterruptedException iex) {
>             // essentially ignore and propagate the interrupt back up
>             LOG.warn("Interrupted while waiting");
>             interrupted = true;
>           }
> {code}
> When thread is interrupted, we shouldn't wait on writestate.flushing anymore.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message