hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19056) TestCompactionInDeadRegionServer is top of the flakies charts!
Date Fri, 20 Oct 2017 06:28:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212245#comment-16212245
] 

Duo Zhang commented on HBASE-19056:
-----------------------------------

As said in the comment, this test is used to confirm that a compaction in dead server will
not cause FNFE as it will fail when writing the compaction marker. But the test is a little
hard to implement because the master will send a YouAreDead message to the RS and the RS will
shutdown itself...

Will take a look to see what's wrong with the current hook.

>  TestCompactionInDeadRegionServer is top of the flakies charts!
> ---------------------------------------------------------------
>
>                 Key: HBASE-19056
>                 URL: https://issues.apache.org/jira/browse/HBASE-19056
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: stack
>
> The test came in recently as part of HBASE-17712 "Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound"
> [~Apache9] when you have a chance, help me out. I was going to just remove the test since
it made no sense to me but then I saw you wrote it  (smile).
> When the region.compact(true); is called on the end, what is supposed to be going on?
> When I trace, the compact is not done because the Region is not writeEnabled (we check
if Region is writeEnabled down in Store before we go ahead and compact). So, I thought the
problem was that the region reference was stale because it came from the rsToSuspend which
had just been killed.
> After a while, I figured that you intend the region reference to be stale so you can
try an append AFTER the WAL has been taken over by WAL splitter.
> But the writeEnabled flag is set so compactions don't run. I tried unsetting this flag
and closed flags and but compaction won't run.
> Was this your intent sir? If so, I'll work w/ it np. Just looking for clarity. Thanks.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message