hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-19052) Backport CellComparatorImpl related changes to branch-1.x
Date Thu, 19 Oct 2017 18:25:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211498#comment-16211498
] 

Anoop Sam John edited comment on HBASE-19052 at 10/19/17 6:24 PM:
------------------------------------------------------------------

The fix for 1.x will contain only the FFT change where if the class name is the new impl class
name, it will fall back to the one what we used to have in all 1.x branches.   In the past
also we did similar things I believe..  So the agreement for the rolling upgrade is that 1st
upgraded to latest 1.x version and then to 2.0. Correct?  Just confirming. 
We may have to change the jira title and desc Ted?


was (Author: anoop.hbase):
The fix for 1.x will contain only the FFT change where if the class name is the new impl class
name, it will fall back to the one what we used to have in all 1.x branches.   In the past
also we did similar things I believe..  So the agreement for the rolling upgrade is that 1st
upgraded to latest 1.x version and then to 2.0. Correct?  Just confirming. 


> Backport CellComparatorImpl related changes to branch-1.x
> ---------------------------------------------------------
>
>                 Key: HBASE-19052
>                 URL: https://issues.apache.org/jira/browse/HBASE-19052
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>
> HBASE-18945 has gone into branch-2 .
> Let's consider rolling upgrade scenario from 1.x to 2.0 where there're three servers:
s1, s2, s3
> s1 is upgraded to 2.0 first. It flushes to hfile in region r1 with CellComparatorImpl
written in the hfile trailer.
> Somehow s1 crashes and master assigns r1 to s2 which is still running 1.x
> The following code in FixedFileTrailer would be triggered:
> {code}
>       try {
>         comparatorKlass = (Class<? extends CellComparator>) Class.forName(comparatorClassName);
>       } catch (ClassNotFoundException e) {
>         throw new IOException(e);
>       }
> {code}
> since s2 is not aware of CellComparatorImpl.
> This issue is to backport CellComparatorImpl related change to branch-1.x
> Note: CellComparatorImpl wouldn't be used in write path, only in read path.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message