hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-19046) RegionObserver#postCompactSelection Avoid passing shaded ImmutableList param
Date Mon, 23 Oct 2017 06:48:00 GMT

     [ https://issues.apache.org/jira/browse/HBASE-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Anoop Sam John updated HBASE-19046:
-----------------------------------
      Resolution: Fixed
    Hadoop Flags: Incompatible change,Reviewed
    Release Note: 
RegionObserver#postCompactSelection signature is changed.
Arg type org.apache.hadoop.hbase.shaded.com.google.common.collect.ImmutableList is replaced
with java.util.List
          Status: Resolved  (was: Patch Available)

Pushed to branch-2+.  Thanks for the review [~chia7712]

> RegionObserver#postCompactSelection  Avoid passing shaded ImmutableList param
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-19046
>                 URL: https://issues.apache.org/jira/browse/HBASE-19046
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-19046.patch, HBASE-19046.patch
>
>
> Dont think there is any specific need for passing this PB type.  We can just pass an
unmodifiableList list object. Javadoc can say this is an unmodifiableList .  Thats it . No
need  that the type itself to be Immutable...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message