hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
Date Fri, 27 Oct 2017 04:55:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221712#comment-16221712
] 

ramkrishna.s.vasudevan commented on HBASE-18995:
------------------------------------------------

[~appy] and [~saint.ack@gmail.com]
Thanks for your comments on RB. I have replied to most of your comments. Let me know what
you think. Patch wise nothing much to change except for renaming to InternalCellUtil to privateCellUtil.
I am fine with any of these two names. I first named it as PrivatecellUtil but since already
@PRivate tag was there I thought InternalCellUtil is better. 

> Move methods that are for internal usage from CellUtil to Private util class
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-18995
>                 URL: https://issues.apache.org/jira/browse/HBASE-18995
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0-alpha-3
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch,
HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch
>
>
> This was brought up long time back. We need to move some of the public APIs from CellUtil
to internal private Util class because they are used in some internal flow and does not make
sense to have it in a @public exposed Util class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message