hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-18993) Backport patches in HBASE-18410 to branch-1.x branches.
Date Thu, 26 Oct 2017 18:14:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220930#comment-16220930
] 

Andrew Purtell edited comment on HBASE-18993 at 10/26/17 6:13 PM:
------------------------------------------------------------------

I think the reported medium severity issue is a real binary compatibility issue. The first
one, the potential for a downstream user's filter to get a NoSuchMethodError on super.<method>
invocation. What do you think?

*Medium severity*

package org.apache.hadoop.hbase.filter
class FilterList  

Superclass has been changed from Filter to FilterBase.

1) Access of a client program to the fields or methods of the old super-class may be interrupted
by NoSuchFieldError or NoSuchMethodError exceptions.

2) A static field from a super-interface of a client class may hide a field (with the same
name) inherited from new super-class and cause IncompatibleClassChangeError exception.

Affected methods: 24 (0.4%)

FilterList.FilterList ( Filter... rowFilters )

FilterList.FilterList ( List<Filter> rowFilters )

FilterList.FilterList ( FilterList.Operator operator )

FilterList.FilterList ( FilterList.Operator operator, Filter... rowFilters )

FilterList.FilterList ( FilterList.Operator operator, List<Filter> rowFilters )

FilterList.addFilter ( Filter filter )

FilterList.filterAllRemaining ( )

FilterList.filterKeyValue ( Cell v )

FilterList.filterRow ( )

FilterList.filterRowCells ( List<Cell> cells )

*Low Severity*

package org.apache.hadoop.hbase.filter
class FilterList  1 

Method Filter.isReversed ( ) has been overridden by FilterList.isReversed ( ). 

Method FilterList.isReversed ( ) will be called instead of Filter.isReversed ( ) in a client
program.

Affected methods: 1 (0.02%)

Filter.isReversed ( )




was (Author: apurtell):
I think the reported medium severity issue is a real binary compatibility issue. What do you
think?

*Medium severity*

package org.apache.hadoop.hbase.filter
class FilterList  

Superclass has been changed from Filter to FilterBase.

1) Access of a client program to the fields or methods of the old super-class may be interrupted
by NoSuchFieldError or NoSuchMethodError exceptions.

2) A static field from a super-interface of a client class may hide a field (with the same
name) inherited from new super-class and cause IncompatibleClassChangeError exception.

Affected methods: 24 (0.4%)

FilterList.FilterList ( Filter... rowFilters )

FilterList.FilterList ( List<Filter> rowFilters )

FilterList.FilterList ( FilterList.Operator operator )

FilterList.FilterList ( FilterList.Operator operator, Filter... rowFilters )

FilterList.FilterList ( FilterList.Operator operator, List<Filter> rowFilters )

FilterList.addFilter ( Filter filter )

FilterList.filterAllRemaining ( )

FilterList.filterKeyValue ( Cell v )

FilterList.filterRow ( )

FilterList.filterRowCells ( List<Cell> cells )

*Low Severity*

package org.apache.hadoop.hbase.filter
class FilterList  1 

Method Filter.isReversed ( ) has been overridden by FilterList.isReversed ( ). 

Method FilterList.isReversed ( ) will be called instead of Filter.isReversed ( ) in a client
program.

Affected methods: 1 (0.02%)

Filter.isReversed ( )



> Backport patches in HBASE-18410 to branch-1.x branches.
> -------------------------------------------------------
>
>                 Key: HBASE-18993
>                 URL: https://issues.apache.org/jira/browse/HBASE-18993
>             Project: HBase
>          Issue Type: Bug
>          Components: Filters
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>             Fix For: 1.4.0, 1.5.0
>
>         Attachments: HBASE-18993-branch-1.1.v1.patch, HBASE-18993-branch-1.2.v1.patch,
HBASE-18993-branch-1.3.v1.patch, HBASE-18993-branch-1.4.v1.patch, HBASE-18993-branch-1.4.v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message