hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiang Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18986) Remove unnecessary null check after CellUtil.cloneQualifier()
Date Fri, 13 Oct 2017 17:03:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203859#comment-16203859
] 

Xiang Li commented on HBASE-18986:
----------------------------------

[~jerryhe], could you please help to review the patch? All UT passed on my local machine,
but I am not able to start Hadoop QA by "Submit patch". Tried a couple of times.

> Remove unnecessary null check after CellUtil.cloneQualifier()
> -------------------------------------------------------------
>
>                 Key: HBASE-18986
>                 URL: https://issues.apache.org/jira/browse/HBASE-18986
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Xiang Li
>            Assignee: Xiang Li
>            Priority: Minor
>         Attachments: HBASE-18986.master.000.patch
>
>
> In master branch,
> {code:title=hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java|borderStyle=solid}
> // From line 2858
> public void prepareDeleteTimestamps(Mutation mutation, Map<byte[], List<Cell>>
familyMap,
>       byte[] byteNow) throws IOException {
>     for (Map.Entry<byte[], List<Cell>> e : familyMap.entrySet()) {
>       // ...
>       for (int i=0; i < listSize; i++) {
>         // ...
>         if (cell.getTimestamp() == HConstants.LATEST_TIMESTAMP && CellUtil.isDeleteType(cell))
{
>           byte[] qual = CellUtil.cloneQualifier(cell);
>           if (qual == null) qual = HConstants.EMPTY_BYTE_ARRAY; // <-- here
>           ...
> {code}
> Might {{if (qual == null) qual = HConstants.EMPTY_BYTE_ARRAY;}} be removed?
> Could it be null after CellUtil.cloneQualifier()?
> {code:title=hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java|borderStyle=solid}
> public static byte[] cloneQualifier(Cell cell){
>   byte[] output = new byte[cell.getQualifierLength()];
>   copyQualifierTo(cell, output, 0);
>   return output;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message