hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-18981) Address issues found by error-prone in hbase-client
Date Tue, 10 Oct 2017 19:09:00 GMT

     [ https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mike Drob updated HBASE-18981:
------------------------------
    Attachment: HBASE-18981.patch

Thanks, Josh! Attaching the trivial fix.

> Address issues found by error-prone in hbase-client
> ---------------------------------------------------
>
>                 Key: HBASE-18981
>                 URL: https://issues.apache.org/jira/browse/HBASE-18981
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Mike Drob
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18981.patch
>
>
> I thought this was something that we would already catch in findbugs, but maybe not?
> {noformat}
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
(default-compile) on project hbase-client: Compilation failure
> [ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5]
[MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or handle the remaining
cases: GLOBAL_BYPASS
> [ERROR]     (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)
> {noformat}
> cc: [~elserj], this looks like it is part of quota code. I'm happy to add a trivial patch
to error on the missing case, but want somebody with more contextual knowledge to look at
it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message