hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18972) Use Builder pattern to remove nullable parameters for coprocessor methods in RawAsyncTable interface
Date Tue, 31 Oct 2017 01:38:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226101#comment-16226101
] 

Duo Zhang commented on HBASE-18972:
-----------------------------------

For specify the inclusive/exclusive of startKey/endKey, I think both approach are OK. You
can say that it is only a single parameter(the start/stop point of a scan) for a scan but
only need two variables to represent, or you can treat them as two separated parameters which
have relations. Both OK. But I have already used the (row, inclusive) pattern in Scan, you
can see the withStartRow and withStopRow in Scan. And they are also introduced in branch-1.x
so I think we'd better keep it in that way.

For other suggestions, seems good. I will upload a new patch to address them.

Thanks.

> Use Builder pattern to remove nullable parameters for coprocessor methods in RawAsyncTable
interface
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18972
>                 URL: https://issues.apache.org/jira/browse/HBASE-18972
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Blocker
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18972-v1.patch, HBASE-18972.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message