hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18951) Use Builder pattern to remove nullable parameters for checkAndXXX methods in RawAsyncTable/AsyncTable interface
Date Tue, 10 Oct 2017 03:24:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198086#comment-16198086
] 

stack commented on HBASE-18951:
-------------------------------

Passing a null once was supposed to signal add the value to the family w/o a qualifier (IIRC).
This was not an especially good idea. Now we'd do it with a qualifier that is zero-byte array?
Does the user have to pass zero-length byte array? Or will it be done for them by the builder;
i.e. convert from null to zero-length byte array. 

i.e. you'd do this inside the checkAndXXX?

    if (qualifier == null) {
      qualifier = HConstants.EMPTY_BYTE_ARRAY;
    }

Thats seems good to me.

> Use Builder pattern to remove nullable parameters for checkAndXXX methods in RawAsyncTable/AsyncTable
interface
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18951
>                 URL: https://issues.apache.org/jira/browse/HBASE-18951
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Blocker
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18951-v1.patch, HBASE-18951.patch
>
>
> As Optional is not supposed to be used as method parameters but we do not want nullable
parameters.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message