hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-18945) Make a Public interface for CellComparator
Date Fri, 06 Oct 2017 18:34:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195000#comment-16195000
] 

Chia-Ping Tsai edited comment on HBASE-18945 at 10/6/17 6:33 PM:
-----------------------------------------------------------------

bq. You have to strike @InterfaceStability.Evolving from CellComparator if you are making
it public.
I remember this (HBASE-17857). It seems the {{CellComparator}} is used for CP only? If so,
is IA.LimitedPrivate better? How do users get {{CellComparator}} impl if it is exposed as
IA.Public?

{code}
public class CellComparatorImpl implements CellComparator {
  static final Log LOG = LogFactory.getLog(CellComparatorImpl.class);
  private static final long serialVersionUID = -8760041766259623329L;
{code}
I guess the serialVersionUID can be removed also.




was (Author: chia7712):
bq. You have to strike @InterfaceStability.Evolving from CellComparator if you are making
it public.
I remember this (HBASE-17857). It seems the {{CellComparator}} is used for CP only? If so,
is IA.LimitedPrivate better? How do user get {{{{CellComparator}} impl if it is exposed as
IA.Public?

{code}
public class CellComparatorImpl implements CellComparator {
  static final Log LOG = LogFactory.getLog(CellComparatorImpl.class);
  private static final long serialVersionUID = -8760041766259623329L;
{code}
I guess the serialVersionUID can be removed also.



> Make a Public interface for CellComparator
> ------------------------------------------
>
>                 Key: HBASE-18945
>                 URL: https://issues.apache.org/jira/browse/HBASE-18945
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18495.patch
>
>
> Based on discussions over in HBASE-18826 and HBASE-18183 it is better we expose CellComparator
as a public interface so that it could be used in Region/Store interfaces to be exposed to
CPs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message