hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18926) Cleanup Optional<T> from method params
Date Thu, 05 Oct 2017 00:55:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192312#comment-16192312
] 

Appy commented on HBASE-18926:
------------------------------

We can change api *after* beta1. So either way, should be okay to fix in beta1, no? 

> Cleanup Optional<T> from method params
> --------------------------------------
>
>                 Key: HBASE-18926
>                 URL: https://issues.apache.org/jira/browse/HBASE-18926
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Appy
>            Assignee: Duo Zhang
>
> ref: Discussion on HBASE-18878
> tldr: Optional is not supposed to be used in method params or class fields (http://dolszewski.com/java/java-8-optional-use-cases/).
We are doing that in some places. Let's revert that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message