hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18925) Need updated mockito for using java optional
Date Thu, 05 Oct 2017 22:58:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193878#comment-16193878

Appy commented on HBASE-18925:

Next hadoop QA is going to be red. The failure in TestZKProcedureControllers was legit. Uploading
new patch.
Not sure about timed out tests though. Let see if they reappear again.

> Need updated mockito for using java optional
> --------------------------------------------
>                 Key: HBASE-18925
>                 URL: https://issues.apache.org/jira/browse/HBASE-18925
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Appy
>            Assignee: Appy
>             Fix For: 2.0.0-beta-1
>         Attachments: HBASE-18925.master.001.patch, HBASE-18925.master.002.patch, HBASE-18925.master.002.patch
> Came up when i was trying to test HBASE-18878.
> It kept failing because mock of RpcCall returned null where return type was Optional<User>.
> Instead, we want it to return Optional.empty(). 
> New mockito versions support this (and other java8 things) - https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2
> We use mockito-all which was last released in Dec2014. However, mockito-core has had
more than 50 releases after that (https://mvnrepository.com/artifact/org.mockito/mockito-core).

> We need to change our deps from mockito-all to mockito-core.
> However that comes with fair breakages, so this is not a simple task of changing pom

This message was sent by Atlassian JIRA

View raw message