hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18893) Remove Add/Modify/DeleteColumnFamilyProcedure in favor of using ModifyTableProcedure
Date Mon, 23 Oct 2017 22:16:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215949#comment-16215949
] 

stack commented on HBASE-18893:
-------------------------------

bq. I'd like to do that as a follow on, however.

Sounds good.

TestCompactionInDeadRegionServer is being dealt with elsewhere in its own issue.

TestReplicaWithCluster seems unrelated.

I already +1'd this nice patch (a few times -- smile)


> Remove Add/Modify/DeleteColumnFamilyProcedure in favor of using ModifyTableProcedure
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-18893
>                 URL: https://issues.apache.org/jira/browse/HBASE-18893
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors, master
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-18893.patch, HBASE-18893.v2.patch, HBASE-18893.v3.patch, HBASE-18893.v4.patch
>
>
> The shell changed from using separate add/modify/delete column calls to funneling everything
through modify table for performance reasons. We know that using modify table works for everything.
Let's drop the old code for Add/Modify/Delete Column so that we have a lower maintenance burden
and fewer code paths to reason about.
> -------- Was: shell 'alter' command no longer distinguishes column add/modify/delete
> After HBASE-15641 all 'alter' commands go through a single modifyTable call at the end,
so we no longer can easily distinguish add, modify, and delete column events. This potentially
affects coprocessors that needed the update notifications for new or removed columns.
> Let's let the shell still make separate behaviour calls like it did before without undoing
the batching that seems pretty useful.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message