hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18884) Coprocessor Design Improvements follow up of HBASE-17732
Date Fri, 06 Oct 2017 19:25:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195100#comment-16195100

Hudson commented on HBASE-18884:

Results for branch HBASE-18467, done in 4 hr 24 min and counting
	[build #136 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18467/136/]:
details (if available):

(x) *{color:red}-1 overall{color}*
    Committer, please check your recent inclusion of a patch for this issue.

(x) {color:red}-1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18467/136//General_Nightly_Build_Report/]

(/) {color:green}+1 jdk8 checks{color}
-- For more information [see jdk8 report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18467/136//JDK8_Nightly_Build_Report/]

(x) {color:red}-1 source release artifact{color}
-- See build output for details.

> Coprocessor Design Improvements follow up of HBASE-17732
> --------------------------------------------------------
>                 Key: HBASE-18884
>                 URL: https://issues.apache.org/jira/browse/HBASE-18884
>             Project: HBase
>          Issue Type: Improvement
>          Components: Coprocessors
>            Reporter: Appy
>            Assignee: Appy
>              Labels: incompatible
>             Fix For: 2.0.0-alpha-4
>         Attachments: addendum.patch, HBASE-18884.master.001.patch
> Creating new jira to track suggestions that came in review (https://reviews.apache.org/r/62141/)
but are not blocker and can be done separately.
> Suggestions by [~apurtell]
> -  Change {{Service Coprocessor#getService()}} to {{List<Service> Coprocessor#getServices()}}
> - I think we overstepped by offering [table resource management via this interface|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java#L57].
There are a lot of other internal resource types which could/should be managed this way but
they are all left up to the implementor. Perhaps we should remove the table ref management
and leave it up to them as well.
> ----
> - Checkin the finalized design doc into repo (https://docs.google.com/document/d/1mPkM1CRRvBMZL4dBQzrus8obyvNnHhR5it2yyhiFXTg/edit)
(fyi: [~stack])
> - Added example to javadoc of Coprocessor base interface on how to implement one in the
new design

This message was sent by Atlassian JIRA

View raw message