hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-18873) Hide protobufs in GlobalQuotaSettings
Date Wed, 11 Oct 2017 22:44:00 GMT

     [ https://issues.apache.org/jira/browse/HBASE-18873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Josh Elser updated HBASE-18873:
    Attachment: HBASE-18873.001.branch-2.patch

.001 This is an attempt to do what I outlined earlier. However, it's a very marginal gain.

At the end of the day, we would have to introduce a significant code change that permeates
all of the quota-persistence server-side (MasterQuotaManager, QuotaUtil, and QuotaTableUtil)
to encapsulate all of the PB logic. This at least doesn't expose users who might get a GlobalQuotaSettings
object to the protobufs, but only lets them merge other QuotaSettings implementations into
it (which may be ok?).

> Hide protobufs in GlobalQuotaSettings
> -------------------------------------
>                 Key: HBASE-18873
>                 URL: https://issues.apache.org/jira/browse/HBASE-18873
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 2.0.0-alpha-4
>         Attachments: HBASE-18873.001.branch-2.patch
> HBASE-18807 cleaned up direct protobuf use in the Coprocessor APIs for quota-related
functions. However, one new POJO introduced to hide these protocol buffers still exposes PBs
via some methods.
> We should try to hide those as well.

This message was sent by Atlassian JIRA

View raw message