hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18805) Unify Admin and AsyncAdmin
Date Thu, 12 Oct 2017 20:05:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202543#comment-16202543
] 

Appy commented on HBASE-18805:
------------------------------

With two admins, which are supposed to be in sync, but no way to ensure that invariant, i
won't be surprised if things slipover over years and we have to do another big  unification
in 3.0. With so many things that can vary - number and types of functions, functions' names,
parameter types, return types, etc - i think it'll be best if we can add a test to ensure
the invariant.
What do you say [~zghaobac]? How about a test which uses reflection on both interfaces to
make sure that things match up? 


> Unify Admin and AsyncAdmin
> --------------------------
>
>                 Key: HBASE-18805
>                 URL: https://issues.apache.org/jira/browse/HBASE-18805
>             Project: HBase
>          Issue Type: Umbrella
>            Reporter: Balazs Meszaros
>             Fix For: 2.0.0-beta-1
>
>
> Admin and AsyncAdmin differ some places:
> - some methods missing from AsyncAdmin (e.g. methods with String regex),
> - some methods have different names (listTables vs listTableDescriptors),
> - some method parameters are different (e.g. AsyncAdmin has Optional<> parameters),
> - AsyncAdmin returns Lists instead of arrays (e.g. listTableNames),
> - unify Javadoc comments,
> - ...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message