hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18770) Remove bypass method in ObserverContext and implement the 'bypass' logic case by case
Date Sun, 29 Oct 2017 20:27:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224187#comment-16224187

stack commented on HBASE-18770:

bq. I used to think whether we can throw an UnsupportedOperationException when users call
bypass in the methods which do not support bypass. Maybe too aggressive?

In the later patch (after your earlier comments), I was able to plug in a DoesNotSupportBypassException.
It is thrown when bypass is called on a method that doesn't allow bypass. I think it better
all around that we give clear, fail fast message. No I don't think it too aggressive (smile).

> Remove bypass method in ObserverContext and implement the 'bypass' logic case by case
> -------------------------------------------------------------------------------------
>                 Key: HBASE-18770
>                 URL: https://issues.apache.org/jira/browse/HBASE-18770
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Duo Zhang
>            Assignee: stack
>            Priority: Critical
>             Fix For: 2.0.0-alpha-4
>         Attachments: HBASE-18770.master.001.patch, HBASE-18770.master.002.patch, HBASE-18770.master.003.patch,
HBASE-18770.master.004.patch, HBASE-18770.master.005.patch, HBASE-18770.master.006.patch,
> http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1

This message was sent by Atlassian JIRA

View raw message