hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18770) Remove bypass method in ObserverContext and implement the 'bypass' logic case by case
Date Thu, 26 Oct 2017 06:54:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220053#comment-16220053

stack commented on HBASE-18770:

Thanks for reviews so far. I think I have a pattern now. Methods that are bypassable are given
the same basic signature; i.e. the return is a bypass boolean and an extra 'result' param
is what we return if bypass is true: e.g:

  default boolean preGetOp(ObserverContext<RegionCoprocessorEnvironment> c, Get get,
      List<Cell> result) throws IOException

This doesn't deviate too much from what was in place for a few methods already.

No more Optional. Don't need it anymore. Was being used so a boolean return could be overloaded
to signify what to return on bypass. We simplified so we don't need this anymore.

I thought I could purge the 'complete' background flag and processing too (complete is how
a CP says skip outstanding CPs in current execution chain, usually used to force bypass result)
but looks like purge would cause a ripple that would take me too long to come back from so
punting for now; will keep on w/ the complete though it is crimped now such that it only applies
to the few methods that support bypass.

Just a status. Am down in the depths doing grunt work to make convertion. More detail to follow.

> Remove bypass method in ObserverContext and implement the 'bypass' logic case by case
> -------------------------------------------------------------------------------------
>                 Key: HBASE-18770
>                 URL: https://issues.apache.org/jira/browse/HBASE-18770
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Duo Zhang
>            Assignee: stack
>            Priority: Critical
>             Fix For: 2.0.0-alpha-4
>         Attachments: HBASE-18770.master.001.patch
> http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1

This message was sent by Atlassian JIRA

View raw message