hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18667) Disable error-prone for hbase-protocol-shaded
Date Thu, 12 Oct 2017 16:55:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202266#comment-16202266
] 

stack commented on HBASE-18667:
-------------------------------

Patch makes sense to me. I tried it.  Seems to do the right thing:

@javax.annotation.Generated("proto") public final class ZooKeeperProtos {

+1

> Disable error-prone for hbase-protocol-shaded
> ---------------------------------------------
>
>                 Key: HBASE-18667
>                 URL: https://issues.apache.org/jira/browse/HBASE-18667
>             Project: HBase
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>             Fix For: 3.0.0
>
>         Attachments: HBASE-18667.patch
>
>
> This is all generated code that we shouldn't be running extra analysis on because it
adds a lot of noise to the build, and also takes a very long time (15 minutes on my machine).
Let's make it fast and simple.
> Even when we run with error-prone enabled for the rest of the build, it should not apply
here.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message