hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18438) Precommit doesn't warn about unused imports
Date Sat, 28 Oct 2017 20:32:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223727#comment-16223727
] 

Chia-Ping Tsai commented on HBASE-18438:
----------------------------------------

The temporary file and the checkstyle message show that the unused imports are caught.
{code}
17:30:07 cd /testptch/hbase/hbase-common
17:30:07 /usr/share/maven/bin/mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-0
checkstyle:checkstyle -Dcheckstyle.consoleOutput=true -DHBasePatchProcess -Ptest-patch >
/testptch/patchprocess/maven-patch-checkstyle-hbase-common.txt 2>&1
17:30:31 cd /testptch/hbase
17:30:31 /usr/share/maven/bin/mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-0
checkstyle:checkstyle -Dcheckstyle.consoleOutput=true -DHBasePatchProcess -Ptest-patch >
/testptch/patchprocess/maven-patch-checkstyle-root.txt 2>&1
17:32:44 
17:32:44 hbase-common: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
17:32:44 
17:32:44 
17:32:44 root: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)
{code}
Will resubmit the job with latest yetus.

> Precommit doesn't warn about unused imports
> -------------------------------------------
>
>                 Key: HBASE-18438
>                 URL: https://issues.apache.org/jira/browse/HBASE-18438
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>            Reporter: Mike Drob
>            Assignee: Chia-Ping Tsai
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: HBASE-18438.patch, HBASE-18438.v2.patch, HBASE-18438.v2.patch
>
>
> On HBASE-18419 I accidentally included an unused import in my patch, but precommit didn't
flag it. Use this issue to diagnose and fix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message