hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17779) disable_table_replication returns misleading message and does not turn off replication
Date Fri, 20 Oct 2017 22:22:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213373#comment-16213373
] 

Hudson commented on HBASE-17779:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-1.3-IT #245 (See [https://builds.apache.org/job/HBase-1.3-IT/245/])
HBASE-17934 Backport HBASE-17779 "disable_table_replication returns (tedyu: rev 1300faffbc37eb0f3962639efa9ff990e80461ed)
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdminWithClusters.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java
HBASE-17934 Backport HBASE-17779 "disable_table_replication returns (tedyu: rev ba76330732d11c3a0f4a2c1b0790a30ef589208f)
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdminWithClusters.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java


> disable_table_replication returns misleading message and does not turn off replication
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-17779
>                 URL: https://issues.apache.org/jira/browse/HBASE-17779
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>            Reporter: Ted Yu
>            Assignee: Janos Gub
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17779-branch-1.patch, HBASE-17779-v2.patch, HBASE-17779.patch
>
>
> Currently HBaseAdmin#isTableRepEnabled() returns false if ANY of the columns families
is not replicated.
> Because of this if you have a table where replication is partially enabled, calling disable_table_replication
will not have any effect, but will report that replication for a given table is disabled.
> Workaround is enabling table replication before disabling. 
> As a solution quoted from HBASE-17460:
> Admin#disableTableReplication() returns nothing and isTableRepEnabled() returns boolean.
For master branch, we can let isTableRepEnabled() return enum (partially disabled, disabled,
etc) This way, Admin#disableTableReplication() can return meaningful value to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message