hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12260) MasterServices needs a short-back-and-sides; pare-back exposure of internals and IA.Private classes
Date Sat, 07 Oct 2017 07:12:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195595#comment-16195595
] 

Hadoop QA commented on HBASE-12260:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 19s{color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  0s{color}
| {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 42 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 16s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 31s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 52s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 40s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m  3s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 43s{color}
| {color:green} branch has no errors when building our shaded downstream artifacts. {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  6m 10s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 19s{color} |
{color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 18s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 23s{color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 15s{color} | {color:red}
hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 14s{color} | {color:red}
hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 23s{color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 14s{color} | {color:red}
hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 15s{color} | {color:red}
hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red}  0m 23s{color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red}  0m 14s{color} | {color:red}
hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red}  0m 15s{color} | {color:red}
hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 23s{color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 14s{color} | {color:red}
hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 15s{color} | {color:red}
hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 39s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m  2s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red}  2m 17s{color} | {color:red}
patch has 38 errors when building our shaded downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  3m 33s{color} | {color:red}
The patch causes 38 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  4m 46s{color} | {color:red}
The patch causes 38 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  6m  0s{color} | {color:red}
The patch causes 38 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  7m 15s{color} | {color:red}
The patch causes 38 errors with Hadoop v2.6.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  8m 29s{color} | {color:red}
The patch causes 38 errors with Hadoop v2.6.5. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  9m 43s{color} | {color:red}
The patch causes 38 errors with Hadoop v2.7.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m 58s{color} | {color:red}
The patch causes 38 errors with Hadoop v2.7.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 12m 12s{color} | {color:red}
The patch causes 38 errors with Hadoop v2.7.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 13m 27s{color} | {color:red}
The patch causes 38 errors with Hadoop v3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red}  0m 23s{color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red}  0m 14s{color} | {color:red}
hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red}  0m 14s{color} | {color:red}
hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 22s{color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 14s{color} | {color:red}
hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 13s{color} | {color:red}
hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 27s{color} | {color:red}
hbase-server generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 26s{color} | {color:green}
hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 29s{color} | {color:green}
hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 23s{color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 15s{color} | {color:red}
hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 14s{color} | {color:red}
hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 33s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 17s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-12260 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12890853/HBASE-12260.master.008.patch
|
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti
 checkstyle  compile  cc  hbaseprotoc  |
| uname | Linux ba52e8d29e77 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / e2ad4c0 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-mvninstall-hbase-server.txt
|
| mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-mvninstall-hbase-rsgroup.txt
|
| mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-mvninstall-hbase-backup.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-compile-hbase-server.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-compile-hbase-rsgroup.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-compile-hbase-backup.txt
|
| cc | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-compile-hbase-server.txt
|
| cc | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-compile-hbase-rsgroup.txt
|
| cc | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-compile-hbase-backup.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-compile-hbase-server.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-compile-hbase-rsgroup.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-compile-hbase-backup.txt
|
| hbaseprotoc | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-hbaseprotoc-hbase-server.txt
|
| hbaseprotoc | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-hbaseprotoc-hbase-rsgroup.txt
|
| hbaseprotoc | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-hbaseprotoc-hbase-backup.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-findbugs-hbase-server.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-findbugs-hbase-rsgroup.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-findbugs-hbase-backup.txt
|
| javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-unit-hbase-rsgroup.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/artifact/patchprocess/patch-unit-hbase-backup.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/testReport/ |
| modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-rsgroup hbase-backup
U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8991/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> MasterServices needs a short-back-and-sides; pare-back exposure of internals and IA.Private
classes
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12260
>                 URL: https://issues.apache.org/jira/browse/HBASE-12260
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master
>            Reporter: ryan rawson
>            Assignee: stack
>            Priority: Critical
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-12260.master.001.patch, HBASE-12260.master.002.patch, HBASE-12260.master.003.patch,
HBASE-12260.master.004.patch, HBASE-12260.master.005.patch, HBASE-12260.master.006.patch,
HBASE-12260.master.007.patch, HBASE-12260.master.008.patch
>
>
> A major issue with MasterServices is the MasterCoprocessorEnvironment exposes this class
even though MasterServices is tagged with @InterfaceAudience.Private
> This means that the entire internals of the HMaster is essentially part of the coprocessor
API.  Many of the classes returned by the MasterServices API are highly internal, extremely
powerful, and subject to constant change.  
> Perhaps a new API to replace MasterServices that is use-case focused, and justified based
on real world co-processors would suit things better.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message