Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 30 Sep 2017 00:34:04 +0000 (UTC)
From: "Appy (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13105276.1506472849000.243093.1506731644195@Atlassian.JIRA>
In-Reply-To: <JIRA.13105276.1506472849000@Atlassian.JIRA>
References: <JIRA.13105276.1506472849000@Atlassian.JIRA> <JIRA.13105276.1506472849247@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-18884) Coprocessor Design Improvements
 follow up of HBASE-17732
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 30 Sep 2017 00:34:14 -0000


    [ https://issues.apache.org/jira/browse/HBASE-18884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186745#comment-16186745 ] 

Appy commented on HBASE-18884:
------------------------------

Pushed addendum.
{noformat}
   /**
-   * Coprocessor endpoints providing protobuf services should implement this interface.
+   * Coprocessor endpoints providing protobuf services should override this method.
+   * @return Iterable of {@link Service}s or empty collection. Implementations should never
+   * return null.
    */
{noformat}

> Coprocessor Design Improvements follow up of HBASE-17732
> --------------------------------------------------------
>
>                 Key: HBASE-18884
>                 URL: https://issues.apache.org/jira/browse/HBASE-18884
>             Project: HBase
>          Issue Type: Improvement
>          Components: Coprocessors
>            Reporter: Appy
>            Assignee: Appy
>              Labels: incompatible
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-18884.master.001.patch
>
>
> Creating new jira to track suggestions that came in review (https://reviews.apache.org/r/62141/) but are not blocker and can be done separately.
> Suggestions by [~apurtell]
> -  Change {{Service Coprocessor#getService()}} to {{List<Service> Coprocessor#getServices()}}
> - I think we overstepped by offering [table resource management via this interface|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java#L57]. There are a lot of other internal resource types which could/should be managed this way but they are all left up to the implementor. Perhaps we should remove the table ref management and leave it up to them as well.
> ----
> - Checkin the finalized design doc into repo (https://docs.google.com/document/d/1mPkM1CRRvBMZL4dBQzrus8obyvNnHhR5it2yyhiFXTg/edit) (fyi: [~stack])
> - Added example to javadoc of Coprocessor base interface on how to implement one in the new design


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)