Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2AC42200D1F for ; Fri, 29 Sep 2017 02:31:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 28FBB1609EC; Fri, 29 Sep 2017 00:31:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 383011609CD for ; Fri, 29 Sep 2017 02:31:11 +0200 (CEST) Received: (qmail 82163 invoked by uid 500); 29 Sep 2017 00:31:10 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 82152 invoked by uid 99); 29 Sep 2017 00:31:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Sep 2017 00:31:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6FFB21A1C57 for ; Fri, 29 Sep 2017 00:31:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.502 X-Spam-Level: X-Spam-Status: No, score=-99.502 tagged_above=-999 required=6.31 tests=[KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id qV0jLNCIWfxO for ; Fri, 29 Sep 2017 00:31:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1F0425FD48 for ; Fri, 29 Sep 2017 00:31:08 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6A4CEE0E9A for ; Fri, 29 Sep 2017 00:31:07 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 92435242BE for ; Fri, 29 Sep 2017 00:31:04 +0000 (UTC) Date: Fri, 29 Sep 2017 00:31:04 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18884) Coprocessor Design Improvements follow up of HBASE-17732 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 29 Sep 2017 00:31:12 -0000 [ https://issues.apache.org/jira/browse/HBASE-18884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185160#comment-16185160 ] Hudson commented on HBASE-18884: -------------------------------- FAILURE: Integrated in Jenkins build HBase-2.0 #594 (See [https://builds.apache.org/job/HBase-2.0/594/]) HBASE-18884 Coprocessor Design Improvements follow up of HBASE-17732 (appy: rev a6a303816cc429db6ed90f634b2d6126f0e8d8fc) * (edit) hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/ColumnAggregationEndpointWithErrors.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * (edit) hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/BulkDeleteEndpoint.java * (edit) hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java * (edit) hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/RowCountEndpoint.java * (edit) hbase-endpoint/src/main/java/org/apache/hadoop/hbase/coprocessor/Export.java * (edit) hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/ColumnAggregationEndpoint.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRowProcessorEndpoint.java * (edit) hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/RefreshHFilesEndpoint.java * (edit) hbase-endpoint/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java * (edit) hbase-endpoint/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/WALCoprocessor.java * (edit) hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/ColumnAggregationEndpointNullResponse.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * (edit) hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorEndpoint.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * (add) dev-support/design-docs/Coprocessor_Design_Improvements-Use_composition_instead_of_inheritance-HBASE-17732-2017_09_27.pdf * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/Coprocessor.java * (edit) hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/ProtobufCoprocessorService.java * (edit) hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestAsyncCoprocessorEndpoint.java * (edit) hbase-endpoint/src/main/java/org/apache/hadoop/hbase/security/access/SecureBulkLoadEndpoint.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorServiceBackwardCompatiblity.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenProvider.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java HBASE-18884 Coprocessor Design Improvements follow up of HBASE-17732; (stack: rev ac933f7af2188f1c834a4d5334880c5f6d5dbc5c) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/Coprocessor.java * (add) dev-support/design-docs/README.txt > Coprocessor Design Improvements follow up of HBASE-17732 > -------------------------------------------------------- > > Key: HBASE-18884 > URL: https://issues.apache.org/jira/browse/HBASE-18884 > Project: HBase > Issue Type: Improvement > Components: Coprocessors > Reporter: Appy > Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18884.master.001.patch > > > Creating new jira to track suggestions that came in review (https://reviews.apache.org/r/62141/) but are not blocker and can be done separately. > Suggestions by [~apurtell] > - Change {{Service Coprocessor#getService()}} to {{List Coprocessor#getServices()}} > - I think we overstepped by offering [table resource management via this interface|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java#L57]. There are a lot of other internal resource types which could/should be managed this way but they are all left up to the implementor. Perhaps we should remove the table ref management and leave it up to them as well. > ---- > - Checkin the finalized design doc into repo (https://docs.google.com/document/d/1mPkM1CRRvBMZL4dBQzrus8obyvNnHhR5it2yyhiFXTg/edit) (fyi: [~stack]) > - Added example to javadoc of Coprocessor base interface on how to implement one in the new design -- This message was sent by Atlassian JIRA (v6.4.14#64029)