Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 56D6E200D11 for ; Mon, 18 Sep 2017 03:45:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5553C1609D9; Mon, 18 Sep 2017 01:45:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9AE021609D8 for ; Mon, 18 Sep 2017 03:45:05 +0200 (CEST) Received: (qmail 36455 invoked by uid 500); 18 Sep 2017 01:45:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 36444 invoked by uid 99); 18 Sep 2017 01:45:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Sep 2017 01:45:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2734B182D5E for ; Mon, 18 Sep 2017 01:45:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 9uNohOyrybKg for ; Mon, 18 Sep 2017 01:45:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E89B05FC80 for ; Mon, 18 Sep 2017 01:45:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 80614E0D6A for ; Mon, 18 Sep 2017 01:45:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8F5072538B for ; Mon, 18 Sep 2017 01:45:00 +0000 (UTC) Date: Mon, 18 Sep 2017 01:45:00 +0000 (UTC) From: "Rajeshbabu Chintaguntla (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 18 Sep 2017 01:45:06 -0000 [ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated HBASE-18829: -------------------------------------------- Attachment: HBASE-18829.patch Here is the patch with the test case simulates the issue at PHOENIX-3111. I agree with [~sergey.soldatov] and [~vincentpoon] that even without this change the functionality of retrying the query can be achieved by checking in the coprocessors that whether splitting/closing happening or not. But with this the HBase itself takes care of retrying when the region closing/splitting without any special handling. > Consider reverting HBASE-14893 Race between mutation on region and region closing operation > ------------------------------------------------------------------------------------------- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Attachments: 18829.v1.txt, HBASE-18829.patch > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the following observations: > * The closing boolean was intended to be acquired before taking the lock ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should properly handle NotServingRegionException without change in locking scheme in hbase -- This message was sent by Atlassian JIRA (v6.4.14#64029)