Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CF2FB200D24 for ; Tue, 19 Sep 2017 04:31:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CDE691609DB; Tue, 19 Sep 2017 02:31:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 245021609DF for ; Tue, 19 Sep 2017 04:31:08 +0200 (CEST) Received: (qmail 30920 invoked by uid 500); 19 Sep 2017 02:31:08 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 30906 invoked by uid 99); 19 Sep 2017 02:31:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Sep 2017 02:31:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A216B1A0C65 for ; Tue, 19 Sep 2017 02:31:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id TP1QKEXmVg-o for ; Tue, 19 Sep 2017 02:31:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id AE6FC5F6C8 for ; Tue, 19 Sep 2017 02:31:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F0321E0ED3 for ; Tue, 19 Sep 2017 02:31:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id BB5AD24158 for ; Tue, 19 Sep 2017 02:31:02 +0000 (UTC) Date: Tue, 19 Sep 2017 02:31:02 +0000 (UTC) From: "Zheng Hu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18806) VerifyRep by snapshot need not to restore snapshot for each mapper MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 19 Sep 2017 02:31:10 -0000 [ https://issues.apache.org/jira/browse/HBASE-18806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171015#comment-16171015 ] Zheng Hu commented on HBASE-18806: ---------------------------------- Hi [~tedyu], Thanks for the reviewing .. Any other concerns for patch v2 ? > VerifyRep by snapshot need not to restore snapshot for each mapper > ------------------------------------------------------------------ > > Key: HBASE-18806 > URL: https://issues.apache.org/jira/browse/HBASE-18806 > Project: HBase > Issue Type: Improvement > Components: Replication > Affects Versions: 2.0.0-alpha-2 > Reporter: Zheng Hu > Assignee: Zheng Hu > Attachments: HBASE-18806.v1.patch, HBASE-18806.v2.patch > > > In following method stack, seems like each mapper task will restore the snapshot. If we verify replication by a snapshot which has many hfiles, then we will take long time to restore snapshot. In our cluster, we took ~30min for the snapshot restoring when verify a big table. > {code} > Verifier.map > |--------> replicatedScanner = new TableSnapshotScanner(...) > |--------> TableSnapshotScanner.init() > |-----> RestoreSnapshotHelper.copySnapshotForScanner > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)