Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 3 Sep 2017 16:27:02 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13099383.1504337084000.17425.1504456022703@Atlassian.JIRA>
In-Reply-To: <JIRA.13099383.1504337084000@Atlassian.JIRA>
References: <JIRA.13099383.1504337084000@Atlassian.JIRA> <JIRA.13099383.1504337084490@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-18743) HFiles in use by a table which has
 the same name and namespace with a default table cloned from snapshot may
 be deleted when that snapshot and default table are deleted
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 03 Sep 2017 16:27:14 -0000


    [ https://issues.apache.org/jira/browse/HBASE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151852#comment-16151852 ] 

Ted Yu commented on HBASE-18743:
--------------------------------

Patch doesn't apply to branch-1

Please attach patch for branch-1

> HFiles in use by a table which has the same name and namespace with a default table cloned from snapshot may be deleted when that snapshot and default table are deleted
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18743
>                 URL: https://issues.apache.org/jira/browse/HBASE-18743
>             Project: HBase
>          Issue Type: Bug
>          Components: hbase
>    Affects Versions: 1.1.12
>            Reporter: wenbang
>            Assignee: wenbang
>            Priority: Critical
>             Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
>         Attachments: HBASE_18743.patch, HBASE_18743_v1.patch, HBASE_18743_v2.patch
>
>
> We recently had a critical production issue in which HFiles that were still in use by a table were deleted.
> This appears to have been caused by conditions in which table have the same namespace and name with a default table cloned from snapshot.when snapshot and default table be deleted,HFiles that are still in use may be deleted.
> For example:
> Table with default namespace is: "t1"
> The namespace of the new table is the same as the name of the default table, and is generated by snapshot cloned : "t1: t1"
> When the snapshot and the default namespace table are deleted, the new table is also deleted in the used HFiles
> This is because the creation of the BackReferenceFile get the table Name is not normal, resulting in can not find the reference file, hfilecleaner to delete the HFiles in used, when the table has not been major compact
> {code:java}
>   public static boolean create(final Configuration conf, final FileSystem fs,
>       final Path dstFamilyPath, final TableName linkedTable, final String linkedRegion,
>       final String hfileName, final boolean createBackRef) throws IOException {
>     String familyName = dstFamilyPath.getName();
>     String regionName = dstFamilyPath.getParent().getName();
>     String tableName = FSUtils.getTableName(dstFamilyPath.getParent().getParent())
>         .getNameAsString();
> {code}
> {code:java}
>   public static TableName getTableName(Path tablePath) {
>     return TableName.valueOf(tablePath.getParent().getName(), tablePath.getName());
>   }
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)