Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 23DD9200D06 for ; Mon, 11 Sep 2017 07:29:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 227421609C0; Mon, 11 Sep 2017 05:29:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4003C1609BD for ; Mon, 11 Sep 2017 07:29:08 +0200 (CEST) Received: (qmail 29909 invoked by uid 500); 11 Sep 2017 05:29:07 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 29893 invoked by uid 99); 11 Sep 2017 05:29:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Sep 2017 05:29:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4B5391A33DA for ; Mon, 11 Sep 2017 05:29:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id KWs83bXcqYXH for ; Mon, 11 Sep 2017 05:29:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EBA2160EF8 for ; Mon, 11 Sep 2017 05:29:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 77F95E0E56 for ; Mon, 11 Sep 2017 05:29:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 23B7624153 for ; Mon, 11 Sep 2017 05:29:00 +0000 (UTC) Date: Mon, 11 Sep 2017 05:29:00 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18733) [compat 1-2] Hide WALKey MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 11 Sep 2017 05:29:09 -0000 [ https://issues.apache.org/jira/browse/HBASE-18733?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D161= 60744#comment-16160744 ]=20 stack commented on HBASE-18733: ------------------------------- WALKey, @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.REPLICATIO= N), changed a bunch for 2.0.0, so much so, we figured it ok purging it sinc= e it was a useless class anyways and CPs using it had to change anyways. Here is list of changes in 2.0.0 for completeness sake. Additions: {code} hbase-server-3.0.0-SNAPSHOT.jar, WALKey.class package org.apache.hadoop.hbase.wal WALKey.estimatedSerializedSizeOf ( ) : long=20 org/apache/hadoop/hbase/wal/WALKey.estimatedSerializedSizeOf:()J WALKey.getBuilder ( WALCellCodec.ByteStringCompressor compressor ) : WALP= rotos.WALKey.Builder=20 org/apache/hadoop/hbase/wal/WALKey.getBuilder:(Lorg/apache/hadoop/hbase/reg= ionserver/wal/WALCellCodec$ByteStringCompressor;)Lorg/apache/hadoop/hbase/s= haded/protobuf/generated/WALProtos$WALKey$Builder; WALKey.getReplicationScopes ( ) : NavigableMap=20 org/apache/hadoop/hbase/wal/WALKey.getReplicationScopes:()Ljava/util/Naviga= bleMap; WALKey.init ( byte[ ] encodedRegionName, TableName tablename, long logSeqNu= m, long now, List clusterIds, long nonceGroup, long nonce, MultiVersi= onConcurrencyControl mvcc, NavigableMap replicationScope )= : void=20 org/apache/hadoop/hbase/wal/WALKey.init:([BLorg/apache/hadoop/hbase/TableNa= me;JJLjava/util/List;JJLorg/apache/hadoop/hbase/regionserver/MultiVersionCo= ncurrencyControl;Ljava/util/NavigableMap;)V WALKey.readFieldsFromPb ( WALProtos.WALKey walKey, WALCellCodec.ByteStringU= ncompressor uncompressor ) : void=20 org/apache/hadoop/hbase/wal/WALKey.readFieldsFromPb:(Lorg/apache/hadoop/hba= se/shaded/protobuf/generated/WALProtos$WALKey;Lorg/apache/hadoop/hbase/regi= onserver/wal/WALCellCodec$ByteStringUncompressor;)V WALKey.serializeReplicationScope ( boolean serialize ) : void=20 org/apache/hadoop/hbase/wal/WALKey.serializeReplicationScope:(Z)V WALKey.setSequenceId ( long sequenceId ) : void=20 org/apache/hadoop/hbase/wal/WALKey.setSequenceId:(J)V WALKey.WALKey ( byte[ ] encodedRegionName, TableName tablename, long logSeq= Num, long now, List clusterIds, long nonceGroup, long nonce, MultiVer= sionConcurrencyControl mvcc, NavigableMap replicationScope= )=20 org/apache/hadoop/hbase/wal/WALKey."":([BLorg/apache/hadoop/hbase/Tab= leName;JJLjava/util/List;JJLorg/apache/hadoop/hbase/regionserver/MultiVersi= onConcurrencyControl;Ljava/util/NavigableMap;)V WALKey.WALKey ( byte[ ] encodedRegionName, TableName tablename, long now, L= ist clusterIds, long nonceGroup, long nonce, MultiVersionConcurrencyC= ontrol mvcc, NavigableMap replicationScope )=20 org/apache/hadoop/hbase/wal/WALKey."":([BLorg/apache/hadoop/hbase/Tab= leName;JLjava/util/List;JJLorg/apache/hadoop/hbase/regionserver/MultiVersio= nConcurrencyControl;Ljava/util/NavigableMap;)V WALKey.WALKey ( byte[ ] encodedRegionName, TableName tablename, long now, M= ultiVersionConcurrencyControl mvcc, NavigableMap replicati= onScope )=20 org/apache/hadoop/hbase/wal/WALKey."":([BLorg/apache/hadoop/hbase/Tab= leName;JLorg/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyContro= l;Ljava/util/NavigableMap;)V WALKey.WALKey ( byte[ ] encodedRegionName, TableName tablename, long now, N= avigableMap replicationScope )=20 org/apache/hadoop/hbase/wal/WALKey."":([BLorg/apache/hadoop/hbase/Tab= leName;JLjava/util/NavigableMap;)V WALKey.WALKey ( NavigableMap replicationScope )=20 org/apache/hadoop/hbase/wal/WALKey."":(Ljava/util/NavigableMap;)V {code} Removed methods: {code} hbase-server-1.2.7-SNAPSHOT.jar, WALKey.class package org.apache.hadoop.hbase.wal WALKey.getBuilder ( WALCellCodec.ByteStringCompressor compressor ) : WALP= rotos.WALKey.Builder=20 org/apache/hadoop/hbase/wal/WALKey.getBuilder:(Lorg/apache/hadoop/hbase/reg= ionserver/wal/WALCellCodec$ByteStringCompressor;)Lorg/apache/hadoop/hbase/p= rotobuf/generated/WALProtos$WALKey$Builder; WALKey.getScopes ( ) : NavigableMap=20 org/apache/hadoop/hbase/wal/WALKey.getScopes:()Ljava/util/NavigableMap; WALKey.getSequenceId ( long maxWaitForSeqId ) : long=20 org/apache/hadoop/hbase/wal/WALKey.getSequenceId:(J)J WALKey.init ( byte[ ] encodedRegionName, TableName tablename, long logSeqNu= m, long now, List clusterIds, long nonceGroup, long nonce, MultiVersi= onConcurrencyControl mvcc ) : void=20 org/apache/hadoop/hbase/wal/WALKey.init:([BLorg/apache/hadoop/hbase/TableNa= me;JJLjava/util/List;JJLorg/apache/hadoop/hbase/regionserver/MultiVersionCo= ncurrencyControl;)V WALKey.readFieldsFromPb ( WALProtos.WALKey walKey, WALCellCodec.ByteStringU= ncompressor uncompressor ) : void=20 org/apache/hadoop/hbase/wal/WALKey.readFieldsFromPb:(Lorg/apache/hadoop/hba= se/protobuf/generated/WALProtos$WALKey;Lorg/apache/hadoop/hbase/regionserve= r/wal/WALCellCodec$ByteStringUncompressor;)V WALKey.readOlderScopes ( NavigableMap scopes ) : void=20 org/apache/hadoop/hbase/wal/WALKey.readOlderScopes:(Ljava/util/NavigableMap= ;)V WALKey.setLogSeqNum ( long sequence ) : void=20 org/apache/hadoop/hbase/wal/WALKey.setLogSeqNum:(J)V WALKey.setScopes ( NavigableMap scopes ) : void=20 org/apache/hadoop/hbase/wal/WALKey.setScopes:(Ljava/util/NavigableMap;)V WALKey.WALKey ( byte[ ] encodedRegionName, TableName tablename )=20 org/apache/hadoop/hbase/wal/WALKey."":([BLorg/apache/hadoop/hbase/Tab= leName;)V {code} The flagged problematic change is this one: {code} hbase-server-1.2.7-SNAPSHOT.jar, WALKey.class package org.apache.hadoop.hbase.wal [=E2=88=92] WALKey.getBuilder ( WALCellCodec.ByteStringCompressor compresso= r ) : WALProtos.WALKey.Builder 1 =20 org/apache/hadoop/hbase/wal/WALKey.getBuilder:(Lorg/apache/hadoop/hbase/reg= ionserver/wal/WALCellCodec$ByteStringCompressor;)Lorg/apache/hadoop/hbase/p= rotobuf/generated/WALProtos$WALKey$Builder; Change=09Effect 1=09Return value type has been changed from org.apache.hadoop.hbase.protobu= f.generated.WALProtos.WALKey.Builder to org.apache.hadoop.hbase.shaded.prot= obuf.generated.WALProtos.WALKey.Builder.=09This method has been removed bec= ause the return type is part of the method signature. A client program may = be interrupted by NoSuchMethodError exception. Other changes were: {code} hbase-server-1.2.7-SNAPSHOT.jar package org.apache.hadoop.hbase.wal [=E2=88=92] class WALKey 7 =20 Change=09Effect 1=09Access level of field clusterIds has been changed from protected to pri= vate.=09A client program may be interrupted by IllegalAccessError exception= . 2=09Access level of field compressionContext has been changed from protecte= d to private.=09A client program may be interrupted by IllegalAccessError e= xception. 3=09Access level of field encodedRegionName has been changed from protected= to private.=09A client program may be interrupted by IllegalAccessError ex= ception. 4=09Access level of field tablename has been changed from protected to priv= ate.=09A client program may be interrupted by IllegalAccessError exception. 5=09Access level of field writeTime has been changed from protected to priv= ate.=09A client program may be interrupted by IllegalAccessError exception. 6=09Field VERSION of type WALKey.Version has been removed from this class.= =09A client program may be interrupted by NoSuchFieldError exception. 7=09Field logSeqNum of type long has been removed from this class.=09A clie= nt program may be interrupted by NoSuchFieldError exception. [+] affected methods: 35 (0.5%)=20 {code} This method changed: {code} hbase-server-1.2.7-SNAPSHOT.jar, WALKey.class package org.apache.hadoop.hbase.wal [=E2=88=92] WALKey.getSequenceId ( ) : long 1 =20 org/apache/hadoop/hbase/wal/WALKey.getSequenceId:()J Change=09Effect 1=09Removed java.io.IOException exception thrown.=09A client program may ch= ange behavior because the removed exception will not be thrown any more and= client will not catch and handle it. {code} > [compat 1-2] Hide WALKey > ------------------------ > > Key: HBASE-18733 > URL: https://issues.apache.org/jira/browse/HBASE-18733 > Project: HBase > Issue Type: Sub-task > Components: API > Reporter: stack > Assignee: Sean Busbey > Fix For: 2.0.0-alpha-3 > > > It has all the below issues and it uses our internal PB. See head of clas= s where it says it should go away... > hbase-server-1.0.0.jar, WALEdit.class > package org.apache.hadoop.hbase.regionserver.wal > [=E2=88=92] WALEdit.getCompaction ( Cell kv ) [static] : WALProtos.Comp= actionDescriptor 1 =20 > org/apache/hadoop/hbase/regionserver/wal/WALEdit.getCompaction:(Lorg/apac= he/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/protobuf/generated/WALProtos= $CompactionDescriptor; > Change=09Effect > 1=09Return value type has been changed from org.apache.hadoop.hbase.proto= buf.generated.WALProtos.CompactionDescriptor to org.apache.hadoop.hbase.sha= ded.protobuf.generated.WALProtos.CompactionDescriptor.=09This method has be= en removed because the return type is part of the method signature. A clien= t program may be interrupted by NoSuchMethodError exception. > [+] WALEdit.getFlushDescriptor ( Cell cell ) [static] : WALProtos.Flush= Descriptor 1 =20 > [+] WALEdit.getRegionEventDescriptor ( Cell cell ) [static] : WALProtos= .RegionEventDescriptor 1 =20 > hbase-server-1.0.0.jar, WALKey.class > package org.apache.hadoop.hbase.wal > [+] WALKey.getBuilder ( WALCellCodec.ByteStringCompressor compressor ) := WALProtos.WALKey.Builder 1 =20 -- This message was sent by Atlassian JIRA (v6.4.14#64029)