Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AA750200CF8 for ; Thu, 14 Sep 2017 09:44:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A97471609CC; Thu, 14 Sep 2017 07:44:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 02BBD1609CE for ; Thu, 14 Sep 2017 09:44:06 +0200 (CEST) Received: (qmail 84944 invoked by uid 500); 14 Sep 2017 07:44:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 84906 invoked by uid 99); 14 Sep 2017 07:44:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Sep 2017 07:44:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7C293D4FDF for ; Thu, 14 Sep 2017 07:44:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XrtrlWh53gXL for ; Thu, 14 Sep 2017 07:44:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E2192610E3 for ; Thu, 14 Sep 2017 07:44:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8FFE8E06C2 for ; Thu, 14 Sep 2017 07:44:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7250F25395 for ; Thu, 14 Sep 2017 07:44:00 +0000 (UTC) Date: Thu, 14 Sep 2017 07:44:00 +0000 (UTC) From: "Kuan-Po Tseng (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18201) add UT and docs for DataBlockEncodingTool MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 14 Sep 2017 07:44:07 -0000 [ https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165905#comment-16165905 ] Kuan-Po Tseng commented on HBASE-18201: --------------------------------------- [~chia7712] May I take over this issue ? > add UT and docs for DataBlockEncodingTool > ----------------------------------------- > > Key: HBASE-18201 > URL: https://issues.apache.org/jira/browse/HBASE-18201 > Project: HBase > Issue Type: Task > Components: tooling > Reporter: Chia-Ping Tsai > Priority: Minor > Labels: beginner > > There is no example, documents, or tests for DataBlockEncodingTool. We should have it friendly if any use case exists. Otherwise, we should just get rid of it because DataBlockEncodingTool presumes that the implementation of cell returned from DataBlockEncoder is KeyValue. The presume may obstruct the cleanup of KeyValue references in the code base of read/write path. -- This message was sent by Atlassian JIRA (v6.4.14#64029)