Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BD710200D06 for ; Mon, 25 Sep 2017 14:51:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BC11B1609E9; Mon, 25 Sep 2017 12:51:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0E63D1609BB for ; Mon, 25 Sep 2017 14:51:06 +0200 (CEST) Received: (qmail 45670 invoked by uid 500); 25 Sep 2017 12:51:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 45659 invoked by uid 99); 25 Sep 2017 12:51:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Sep 2017 12:51:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BA32C1844AA for ; Mon, 25 Sep 2017 12:51:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id hFba0TGsAqCD for ; Mon, 25 Sep 2017 12:51:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 64B6B5F4A9 for ; Mon, 25 Sep 2017 12:51:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C54E8E0F74 for ; Mon, 25 Sep 2017 12:51:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6A47B2425E for ; Mon, 25 Sep 2017 12:51:02 +0000 (UTC) Date: Mon, 25 Sep 2017 12:51:02 +0000 (UTC) From: "Zheng Hu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-18160) Fix incorrect logic in FilterList.filterKeyValue MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 25 Sep 2017 12:51:07 -0000 [ https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated HBASE-18160: ----------------------------- Attachment: (was: HBASE-18160.branch-1.v1.patch) > Fix incorrect logic in FilterList.filterKeyValue > ------------------------------------------------- > > Key: HBASE-18160 > URL: https://issues.apache.org/jira/browse/HBASE-18160 > Project: HBase > Issue Type: Sub-task > Reporter: Zheng Hu > Assignee: Zheng Hu > Attachments: filter-and-map.txt, filter-or-map.txt, HBASE-18160.branch-1.3.v1.patch, HBASE-18160.branch-1.4.v1.patch, HBASE-18160.v1.patch, HBASE-18160.v2.patch, HBASE-18160.v2.patch, HBASE-18160.v3.patch, HBASE-18160.v4.patch, HBASE-18160.v5.patch, HBASE-18160.v6.patch, HBASE-18160.v6.patch, HBASE-18160.v7.patch, HBASE-18160.v8.patch > > > As HBASE-17678 said, there are two problems in FilterList.filterKeyValue implementation: > 1. FilterList did not consider INCLUDE_AND_SEEK_NEXT_ROW case( seems like INCLUDE_AND_SEEK_NEXT_ROW is a newly added case, and the dev forgot to consider FilterList), So if a user use INCLUDE_AND_SEEK_NEXT_ROW in his own Filter and wrapped by a FilterList, it'll throw an IllegalStateException("Received code is not valid."). > 2. For FilterList with MUST_PASS_ONE, if filter-A in filter list return INCLUDE and filter-B in filter list return INCLUDE_AND_NEXT_COL, the FilterList will return INCLUDE_AND_NEXT_COL finally. According to the mininal step rule , It's incorrect. (filter list with MUST_PASS_ONE choose the mininal step among filters in filter list. Let's call it: The Mininal Step Rule). -- This message was sent by Atlassian JIRA (v6.4.14#64029)