Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 21 Sep 2017 17:35:00 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13009794.1475652842000.168552.1506015300694@Atlassian.JIRA>
In-Reply-To: <JIRA.13009794.1475652842000@Atlassian.JIRA>
References: <JIRA.13009794.1475652842000@Atlassian.JIRA> <JIRA.13009794.1475652842194@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-16769) Deprecate/remove PB references
 from MasterObserver and RegionServerObserver
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 21 Sep 2017 17:35:05 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175167#comment-16175167 ] 

stack commented on HBASE-16769:
-------------------------------

bq. That time the hook was added as general purpose thing.. But ya may be not really needed.. Ya for AC there is no need to see the cells which are replicated. AC wants to know the user and his permission levels only. 

Ok.

So, we think this method is going to go away in 3.0... hopefully because AC gets off CP and becomes integral? If so, we should try not to keep people off it.

The bad thing though is that if the method is in the Interface, they'll have to implement it, right? Unless we do the @appy refactor first and put in place defaults?

If we can have jdk8 defaults, then I like your idea of deprecate+private+don't use because for AC which is going internal....


> Deprecate/remove PB references from MasterObserver and RegionServerObserver
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-16769
>                 URL: https://issues.apache.org/jira/browse/HBASE-16769
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Blocker
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-16769.patch, HBASE-16769_V2.patch
>
>
> This is effectively a sub-task for HBASE-15174.
> CP Methods
> MasterObserver
> 	preListSnapshot
> 	postListSnapshot
> 	preSnapshot
> 	postSnapshot
> 	preCloneSnapshot
> 	postCloneSnapshot
> 	preRestoreSnapshot
> 	postRestoreSnapshot
> 	preDeleteSnapshot
> 	postDeleteSnapshot
> 	
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetTableQuota
> 	postSetTableQuota
> 	preSetNamespaceQuota
> 	postSetNamespaceQuota
> 	
> RegionServerObserver
> 	preReplicateLogEntries
> 	postReplicateLogEntries
> Note : This issue not handling Quota related CPs.  Same is handled by a subtask here HBase-18807


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)