Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 122CA200D0E for ; Tue, 12 Sep 2017 01:48:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 10C611609C5; Mon, 11 Sep 2017 23:48:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5872D1609C4 for ; Tue, 12 Sep 2017 01:48:04 +0200 (CEST) Received: (qmail 2296 invoked by uid 500); 11 Sep 2017 23:48:03 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 2285 invoked by uid 99); 11 Sep 2017 23:48:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Sep 2017 23:48:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0F4B61A679E for ; Mon, 11 Sep 2017 23:48:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id qsJVFDg4bwQm for ; Mon, 11 Sep 2017 23:48:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 994885F5B3 for ; Mon, 11 Sep 2017 23:48:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DF62EE0059 for ; Mon, 11 Sep 2017 23:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 954AC24147 for ; Mon, 11 Sep 2017 23:48:00 +0000 (UTC) Date: Mon, 11 Sep 2017 23:48:00 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16480) Merge WALEdit and WALKey MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 11 Sep 2017 23:48:05 -0000 [ https://issues.apache.org/jira/browse/HBASE-16480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162247#comment-16162247 ] stack commented on HBASE-16480: ------------------------------- Even if we just cut down size of WALKey and WALEdit. A WALEntry has a WALKey and a WALEdit. The WALEdit has full RegionInfo. The WALKey has regioninfo encoded AND table name (repeated info). The WALKey carries an mvcc and a writeEntry instance though all it wants is the resultant sequenceid... which is managed by another object altogether, the FSWALEntry -- which has no mvcc. Needs some work. > Merge WALEdit and WALKey > ------------------------ > > Key: HBASE-16480 > URL: https://issues.apache.org/jira/browse/HBASE-16480 > Project: HBase > Issue Type: Sub-task > Components: wal > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-16480.master.001.patch > > > No need for separate classes: > {code} > // TODO: Key and WALEdit are never used separately, or in one-to-many relation, for practical > // purposes. They need to be merged into WALEntry. > @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.REPLICATION) > public class WALKey implements SequenceId, Comparable { > {code} > Will reduce garbage a little and simplify code. We can get rid of WAL.Entry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)