Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B148C200CEF for ; Mon, 4 Sep 2017 14:04:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B00EE164D07; Mon, 4 Sep 2017 12:04:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0A221164D05 for ; Mon, 4 Sep 2017 14:04:08 +0200 (CEST) Received: (qmail 69275 invoked by uid 500); 4 Sep 2017 12:04:07 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 69261 invoked by uid 99); 4 Sep 2017 12:04:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Sep 2017 12:04:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EC6C5D34E0 for ; Mon, 4 Sep 2017 12:04:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Z19Byn9AW2Mg for ; Mon, 4 Sep 2017 12:04:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CC9A260F06 for ; Mon, 4 Sep 2017 12:04:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D8FC3E0EF0 for ; Mon, 4 Sep 2017 12:04:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4791824166 for ; Mon, 4 Sep 2017 12:04:00 +0000 (UTC) Date: Mon, 4 Sep 2017 12:04:00 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 04 Sep 2017 12:04:09 -0000 [ https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152528#comment-16152528 ] Hudson commented on HBASE-15497: -------------------------------- FAILURE: Integrated in Jenkins build HBase-2.0 #453 (See [https://builds.apache.org/job/HBase-2.0/453/]) HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and (chia7712: rev a1efda29e9f89f6ded192213e90164c7a221f041) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java > Incorrect javadoc for atomicity guarantee of Increment and Append > ----------------------------------------------------------------- > > Key: HBASE-15497 > URL: https://issues.apache.org/jira/browse/HBASE-15497 > Project: HBase > Issue Type: Bug > Components: documentation > Affects Versions: 2.0.0 > Reporter: Jianwei Cui > Assignee: Jianwei Cui > Priority: Minor > Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3 > > Attachments: HBASE-15497-v1.patch > > > At the front of {{Increment.java}} file, there is comment about read atomicity: > {code} > * This operation does not appear atomic to readers. Increments are done > * under a single row lock, so write operations to a row are synchronized, but > * readers do not take row locks so get and scan operations can see this > * operation partially completed. > {code} > It seems this comment is not true after MVCC integrated [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the readers can be guaranteed to read the whole result of Increment if I am not wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}} and {{Table#increment(...)}} -- This message was sent by Atlassian JIRA (v6.4.14#64029)