Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 18 Sep 2017 17:41:01 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12841977.1435753971000.138446.1505756461122@Atlassian.JIRA>
In-Reply-To: <JIRA.12841977.1435753971000@Atlassian.JIRA>
References: <JIRA.12841977.1435753971000@Atlassian.JIRA> <JIRA.12841977.1435753971889@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-14004) [Replication] Inconsistency
 between Memstore and WAL may result in data in remote cluster that is not
 in the origin
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 18 Sep 2017 17:41:09 -0000


    [ https://issues.apache.org/jira/browse/HBASE-14004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170374#comment-16170374 ] 

Ted Yu commented on HBASE-14004:
--------------------------------

TestReplicationSmallTests fails consistently on master.

If I switch to commit f7a986cb67b55e36b58bf4b4934a2f32f29f538a, the test passes.

Duo:
Can you check ?

> [Replication] Inconsistency between Memstore and WAL may result in data in remote cluster that is not in the origin
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14004
>                 URL: https://issues.apache.org/jira/browse/HBASE-14004
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver, Replication
>            Reporter: He Liangliang
>            Assignee: Duo Zhang
>            Priority: Critical
>              Labels: replication, wal
>             Fix For: 3.0.0, 2.0.0-alpha-4
>
>         Attachments: HBASE-14004.patch, HBASE-14004-v1.patch, HBASE-14004-v2.patch, HBASE-14004-v2.patch, HBASE-14004-v3.patch
>
>
> Looks like the current write path can cause inconsistency between memstore/hfile and WAL which cause the slave cluster has more data than the master cluster.
> The simplified write path looks like:
> 1. insert record into Memstore
> 2. write record to WAL
> 3. sync WAL
> 4. rollback Memstore if 3 fails
> It's possible that the HDFS sync RPC call fails, but the data is already  (may partially) transported to the DNs which finally get persisted. As a result, the handler will rollback the Memstore and the later flushed HFile will also skip this record.
> ==================================
> This is a long lived issue. The above problem is solved by write path reorder, as now we will sync wal first before modifying memstore. But the problem may still exists as replication thread may read the new data before we return from hflush. See this document for more details:
> https://docs.google.com/document/d/11AyWtGhItQs6vsLRIx32PwTxmBY3libXwGXI25obVEY/edit#
> So we need to keep a sync length in WAL and tell replication wal reader this is limit when you read this wal file.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)