Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0D844200CE6 for ; Fri, 15 Sep 2017 12:37:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0C3651609D3; Fri, 15 Sep 2017 10:37:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 528881609D1 for ; Fri, 15 Sep 2017 12:37:10 +0200 (CEST) Received: (qmail 36290 invoked by uid 500); 15 Sep 2017 10:37:09 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 36274 invoked by uid 99); 15 Sep 2017 10:37:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Sep 2017 10:37:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DF7D9C436E for ; Fri, 15 Sep 2017 10:37:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id JJ_B6jVhQhRm for ; Fri, 15 Sep 2017 10:37:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 790B65FDBC for ; Fri, 15 Sep 2017 10:37:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9139AE0F16 for ; Fri, 15 Sep 2017 10:37:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D6CA325399 for ; Fri, 15 Sep 2017 10:37:01 +0000 (UTC) Date: Fri, 15 Sep 2017 10:37:01 +0000 (UTC) From: "Tamas Penzes (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-13346) Clean up Filter package for post 1.0 s/KeyValue/Cell/g MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 15 Sep 2017 10:37:11 -0000 [ https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated HBASE-13346: --------------------------------- Status: Patch Available (was: In Progress) > Clean up Filter package for post 1.0 s/KeyValue/Cell/g > ------------------------------------------------------ > > Key: HBASE-13346 > URL: https://issues.apache.org/jira/browse/HBASE-13346 > Project: HBase > Issue Type: Bug > Components: API, Filters > Affects Versions: 2.0.0 > Reporter: Lars George > Assignee: Tamas Penzes > Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-13346.master.001.patch > > > Since we have a bit of a messy Filter API with KeyValue vs Cell reference mixed up all over the place, I recommend cleaning this up once and for all. There should be no {{KeyValue}} (or {{kv}}, {{kvs}} etc.) in any method or parameter name. > This includes deprecating and renaming filters too, for example {{FirstKeyOnlyFilter}}, which really should be named {{FirstKeyValueFilter}} as it does _not_ just return the key, but the entire cell. It should be deprecated and renamed to {{FirstCellFilter}} (or {{FirstColumnFilter}} if you prefer). > In general we should clarify and settle on {{KeyValue}} vs {{Cell}} vs {{Column}} in our naming. The latter two are the only ones going forward with the public API, and are used synonymous. We should carefully check which is better suited (is it really a specific cell, or the newest cell, aka the newest column value) and settle on a naming schema. -- This message was sent by Atlassian JIRA (v6.4.14#64029)