Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4C265200D04 for ; Mon, 11 Sep 2017 08:57:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4AC211609C4; Mon, 11 Sep 2017 06:57:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8FFCF1609C3 for ; Mon, 11 Sep 2017 08:57:06 +0200 (CEST) Received: (qmail 9833 invoked by uid 500); 11 Sep 2017 06:57:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 9822 invoked by uid 99); 11 Sep 2017 06:57:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Sep 2017 06:57:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0EC5619531A for ; Mon, 11 Sep 2017 06:57:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id YTAYfemTW-V9 for ; Mon, 11 Sep 2017 06:57:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6915D5F6BE for ; Mon, 11 Sep 2017 06:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D509DE0EEF for ; Mon, 11 Sep 2017 06:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3F7F824158 for ; Mon, 11 Sep 2017 06:57:00 +0000 (UTC) Date: Mon, 11 Sep 2017 06:57:00 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 11 Sep 2017 06:57:07 -0000 [ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160811#comment-16160811 ] ramkrishna.s.vasudevan commented on HBASE-10944: ------------------------------------------------ bq.Am fine with expsosing it for Cells. Add a clear comment saying avoid using in the actual code. Sorry. I meant that we will expose it for KVs and for the KV#getBuffer() add a clear comment saying that we only work with Cells. bq.Can we resolve this and the parent? Is that presumptious? Or we waiting on the MR change to complete? We can close this now. Both PrefixTree and RowIndexCodecV1 use this only for test cases. So we are good now to close this. MR can be done seperately because as I said there is no reference to KV.getBuffer() so probably not directly referring to what this JIRA does. > Remove all kv.getBuffer() and kv.getRow() references existing in the code > ------------------------------------------------------------------------- > > Key: HBASE-10944 > URL: https://issues.apache.org/jira/browse/HBASE-10944 > Project: HBase > Issue Type: Sub-task > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Priority: Critical > Fix For: 1.5.0, 2.0.0-alpha-3 > > > kv.getRow() and kv.getBuffers() are still used in places to form key byte[] and row byte[]. Removing all such instances including testcases will make the usage of Cell complete. -- This message was sent by Atlassian JIRA (v6.4.14#64029)