hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pankaj Kumar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null
Date Wed, 27 Sep 2017 12:19:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182463#comment-16182463
] 

Pankaj Kumar commented on HBASE-18874:
--------------------------------------

Sorry for late reply [~tedyu], currently this issue is applicable only for branch-2 and master.
 

In other branches we are invoking HRegionServer's stop(String) which will log the message,

{code}
  public void abort(final String msg, final Throwable t) {
    if (isAborted() || isStopped()) {
      return;
    }
    if (cpHost != null) {
      // HBASE-4014: dump a list of loaded coprocessors.
      LOG.fatal("Master server abort: loaded coprocessors are: " +
          getLoadedCoprocessors());
    }
    if (t != null) LOG.fatal(msg, t);
    stop(msg);
  }
{code}


Actually this issue was introduced by HBASE-14499 in master branch and we missed to fix HBASE-14499
in branch-1 and other branches as well. Shall I backport first HBASE-14499 to other branches?

> HMaster abort message will be skipped if Throwable is passed null
> -----------------------------------------------------------------
>
>                 Key: HBASE-18874
>                 URL: https://issues.apache.org/jira/browse/HBASE-18874
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>            Priority: Minor
>         Attachments: HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is not null,
> {noformat}
>     if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message