hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-18853) hbase-protocol-shaded includes protobuf (since we moved to hbase-thirdparty)
Date Wed, 20 Sep 2017 03:40:00 GMT

     [ https://issues.apache.org/jira/browse/HBASE-18853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-18853:
--------------------------
    Description: 
I didn't follow my own comment when I added hbase-thirdparty hbase-shaded-protobuf to hbase-shaded-protocol
as a dependency instead of original protobuf. It meant that our jar had protobuf bundled up
inside it.

Change is small, and I don't think we were actually using the non-shaded protobuf anywhere,
but if anyone was, it'd make for interesting issue to debug. Let me see if it breaks anything...

(Found by our [~vickyuec] on internal deploy...)

  was:
I didn't follow my own comment when I adde hbase-thirdparty hbase-shaded-protobuf to hbase-shaded-protocol
as a dependency instead of protobuf so our jar had protobuf bundled up inside it.

Change is small but let me see if it breaks anything...

(Found by our Vikram on internal deploy...)


> hbase-protocol-shaded includes protobuf (since we moved to hbase-thirdparty)
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-18853
>                 URL: https://issues.apache.org/jira/browse/HBASE-18853
>             Project: HBase
>          Issue Type: Bug
>          Components: thirdparty
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0-alpha-4
>
>
> I didn't follow my own comment when I added hbase-thirdparty hbase-shaded-protobuf to
hbase-shaded-protocol as a dependency instead of original protobuf. It meant that our jar
had protobuf bundled up inside it.
> Change is small, and I don't think we were actually using the non-shaded protobuf anywhere,
but if anyone was, it'd make for interesting issue to debug. Let me see if it breaks anything...
> (Found by our [~vickyuec] on internal deploy...)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message