hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18847) remove unneeded synchronized block from hfilev2 warning in branch-1.2
Date Thu, 21 Sep 2017 21:47:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175515#comment-16175515
] 

Hadoop QA commented on HBASE-18847:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  4s{color} | {color:red}
HBASE-18847 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18847 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12888375/HBASE-18847.v1.patch
|
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8730/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> remove unneeded synchronized block from hfilev2 warning in branch-1.2
> ---------------------------------------------------------------------
>
>                 Key: HBASE-18847
>                 URL: https://issues.apache.org/jira/browse/HBASE-18847
>             Project: HBase
>          Issue Type: Bug
>          Components: Performance
>    Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>            Reporter: Rich Howarth
>            Assignee: Rich Howarth
>            Priority: Critical
>             Fix For: 1.2.7
>
>         Attachments: HBASE-18847.v1.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level synchronization
in a heavily used code path has a demonstrably significant negative effect on performance.
I tested forcing a major compaction with 18 compaction threads per node; removing the synchronization
resulted in an order of magnitude performance increase, with the bottleneck then being at
the disks (where I want it to be).
> {code:java}
>     synchronized (HFileWriterV2.class) {
>       if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
>         LOG.warn("A minimum HFile version of " + HFile.MIN_FORMAT_VERSION_WITH_TAGS
>           + " is required to support cell attributes/tags. Consider setting "
>           + HFile.FORMAT_VERSION_KEY + " accordingly.");
>         WARN_CELL_WITH_TAGS = false;
>       }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message