hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18834) fix shellcheck warning on hbase personality
Date Mon, 18 Sep 2017 05:49:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169627#comment-16169627
] 

Hadoop QA commented on HBASE-18834:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 21s{color} | {color:blue}
Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  4s{color} | {color:blue}
Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m  7s{color}
| {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red}  4m 42s{color} | {color:red}
branch has 12 errors when building our shaded downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m  6s{color}
| {color:green} The patch generated 0 new + 497 unchanged - 2 fixed = 497 total (was 499)
{color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red}  3m 57s{color} | {color:red}
patch has 12 errors when building our shaded downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 36m 33s{color}
| {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5
2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 13s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 47m 15s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18834 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12887606/HBASE-18834.0.patch
|
| Optional Tests |  asflicense  shadedjars  shellcheck  shelldocs  |
| uname | Linux 64b5bd05ac8b 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 190a660 |
| shellcheck | v0.4.6 |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8672/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> fix shellcheck warning on hbase personality
> -------------------------------------------
>
>                 Key: HBASE-18834
>                 URL: https://issues.apache.org/jira/browse/HBASE-18834
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>         Attachments: HBASE-18834.0.patch
>
>
> current shellcheck gives us two warnings:
> {code}
> $ shellcheck dev-support/hbase-personality.sh 
> In dev-support/hbase-personality.sh line 123:
>         if [[ $? -eq 0 ]]; then
>               ^-- SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly
with $?.
> In dev-support/hbase-personality.sh line 136:
>         if [[ $? -eq 0 ]]; then
>               ^-- SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly
with $?.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message