hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Soldatov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
Date Fri, 15 Sep 2017 23:26:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168671#comment-16168671
] 

Sergey Soldatov commented on HBASE-18829:
-----------------------------------------

[~lhofhansl] I have strong feeling that  Phoenix code is not relying on this behavior anymore
([~jamestaylor] and [~rajeshbabu] may correct me). Initially HBASE-14893 was introduced to
avoid failing batchMutate because of closing state. Right now Phoenix is waiting for the completeness
of batch mutations in preClose(), so closing state would not be set until we complete (or
fail) our operations. 

> Consider reverting HBASE-14893 Race between mutation on region and region closing operation
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18829
>                 URL: https://issues.apache.org/jira/browse/HBASE-18829
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 18829.v1.txt
>
>
> HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111.
> This issue is to consider reverting the fix from HBASE-14893 based on the following observations:
> * The closing boolean was intended to be acquired before taking the lock ([~enis])
> * Phoenix local index has evolved over the years, the situation leading to NotServingRegionException
may not exist from Phoenix side
> * Even if the situation still exists, downstream project (Phoenix) should properly handle
NotServingRegionException without change in locking scheme in hbase



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message