hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18807) Remove PB references from Observers for Quotas
Date Sun, 24 Sep 2017 19:09:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178316#comment-16178316
] 

Josh Elser commented on HBASE-18807:
------------------------------------

bq. Sorry for being late here

No worries! I wanted to make sure I ran it by you.

bq. GlobalQuotaSettings , I can see states like QuotaProtos.Throttle and getters for that

Yeah, that's going to be even more work to untangle. For whatever reason, the ThrottleSettings
and related PB messages aren't bidirectional when it comes to serialization and all of the
server-side code was written expecting the Quotas PB object.

If it's OK with you, I'd like to work on that in a follow-on (which I would like to get done
in time for alpha4) to change GlobalQuotaSettings to not expose PBs either.

> Remove PB references from Observers for Quotas
> ----------------------------------------------
>
>                 Key: HBASE-18807
>                 URL: https://issues.apache.org/jira/browse/HBASE-18807
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 3.0.0, 2.0.0-alpha-4
>
>         Attachments: HBASE-18807.001.branch-2.patch, HBASE-18807.002.branch-2.patch,
HBASE-18807.003.branch-2.patch, HBASE-18807.004.branch-2.patch
>
>
> Break-out from the parent:
> Same idea, just applied to the Observer methods for pre/post quota operations. Requires
changes to MasterQuotaManager and the QuotaSettings implementations as some business logic
is written on the PB objects directly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message