hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18807) Remove PB references from Observers for Quotas
Date Sun, 24 Sep 2017 11:55:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178171#comment-16178171

Anoop Sam John commented on HBASE-18807:

Sorry for being late here.
GlobalQuotaSettings , I can see states like QuotaProtos.Throttle and getters for that.   So
we expect CP users to make use of these PB objects via the getters and do some thing?   This
also should NOT be ideally happening..  PB is our internal stuff and we should not expose
that to the users.  If we are not doing that, we can change our PB stuff (Like the shading
what we did recently) with out much worry.  

> Remove PB references from Observers for Quotas
> ----------------------------------------------
>                 Key: HBASE-18807
>                 URL: https://issues.apache.org/jira/browse/HBASE-18807
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 3.0.0, 2.0.0-alpha-4
>         Attachments: HBASE-18807.001.branch-2.patch, HBASE-18807.002.branch-2.patch,
HBASE-18807.003.branch-2.patch, HBASE-18807.004.branch-2.patch
> Break-out from the parent:
> Same idea, just applied to the Observer methods for pre/post quota operations. Requires
changes to MasterQuotaManager and the QuotaSettings implementations as some business logic
is written on the PB objects directly.

This message was sent by Atlassian JIRA

View raw message