hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tamas Penzes (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-18797) Deprecate Filter#filterKeyValue and add Filter#filterCell
Date Fri, 15 Sep 2017 12:52:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167816#comment-16167816
] 

Tamas Penzes edited comment on HBASE-18797 at 9/15/17 12:51 PM:
----------------------------------------------------------------

Why not having a much more simple solution?

* Rename filterKeyValue(Cell kv) to filterCell(Cell c) everywhere
* Create abstract filterCell(Cell c); in Filter.java
* Create non abstract @Deprecated filterKeyValue(Cell c){ return filterCell(c);} in Filter.java.

This way filterKeyValue would be deprecated everywhere, as requested by the tickets creator,
but would still work.
The same functionality would be available as filterCell as well.

Simple, short solution, with minimal changes.


was (Author: tamaas):
Why not having a much more simple solution?

* Rename filterKeyValue(Cell kv) to filterCell(Cell c) everywhere
* Create non abstract @Deprecated filterKeyValue(Cell c){ return filterCell(c);} in Filter.java.

This way filterKeyValue would be deprecated everywhere, as requested by the tickets creator,
but would still work.
The same functionality would be available as filterCell as well.

Simple, short solution, with minimal changes.

> Deprecate Filter#filterKeyValue and add Filter#filterCell
> ---------------------------------------------------------
>
>                 Key: HBASE-18797
>                 URL: https://issues.apache.org/jira/browse/HBASE-18797
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API, Filters
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>            Priority: Critical
>             Fix For: 2.0.0-alpha-3
>
>
> Part of filter package cleanup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message